Draft
Conversation
Vika-F
reviewed
Mar 31, 2026
Vika-F
reviewed
Mar 31, 2026
Vika-F
reviewed
Mar 31, 2026
Contributor
Author
|
/intelci: run |
Vika-F
reviewed
Apr 2, 2026
| @@ -0,0 +1,60 @@ | |||
| /* file: engine_factory.cpp */ | |||
| /******************************************************************************* | |||
| * Copyright 2014 Intel Corporation | |||
Contributor
There was a problem hiding this comment.
Suggested change
| * Copyright 2014 Intel Corporation | |
| * Copyright contributors to the oneDAL project |
Contributor
There was a problem hiding this comment.
Please update the copyright here and in the other similar places.
Vika-F
reviewed
Apr 2, 2026
|
|
||
| #include <daal/src/externals/service_rng.h> | ||
| #include <daal/include/algorithms/engines/mcg59/mcg59.h> | ||
| #include "src/algorithms/engines/mcg59/mcg59.h" |
Contributor
There was a problem hiding this comment.
this way it will be aligned with the other includes:
Suggested change
| #include "src/algorithms/engines/mcg59/mcg59.h" | |
| #include <daal/src/algorithms/engines/mcg59/mcg59.h> |
Vika-F
approved these changes
Apr 2, 2026
Contributor
Vika-F
left a comment
Vika-F
left a comment
There was a problem hiding this comment.
Approving with a couple of minor comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist:
Completeness and readability
Testing
Performance